Skip to content

Add basics/account-data/poseidon #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Add basics/account-data/poseidon #224

wants to merge 9 commits into from

Conversation

@0xCipherCoder
Copy link
Contributor

@0xCipherCoder 0xCipherCoder commented Oct 26, 2024

  • Added an account data example using the Poseidon using Bankrun tests.

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. account-data basics/account-data labels Nov 15, 2024
heyAyushh
heyAyushh previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyAyushh
Copy link
Member

heyAyushh commented Nov 25, 2024

@0xCipherCoder can you check why tests are failing?

@heyAyushh heyAyushh self-requested a review November 25, 2024 14:06
@heyAyushh heyAyushh dismissed their stale review November 25, 2024 14:07

Tests failed

@0xCipherCoder
Copy link
Contributor Author

0xCipherCoder commented Nov 25, 2024

@0xCipherCoder can you check why tests are failing?

Yes checking

@0xCipherCoder
Copy link
Contributor Author

0xCipherCoder commented Nov 25, 2024 •
edited
Loading

@heyAyushh Just checked on local tests are working fine.
Test-Result

But on CI getting type errors -

` 2 failing

1) Address Info Program
     initialize
       creates new address info:
   TypeError: addressProgram.methods.initialize is not a function
    at /home/runner/work/program-examples/program-examples/basics/account-data/poseidon/tests/account_data.ts:50:10
    at Generator.next (<anonymous>)
    at /home/runner/work/program-examples/program-examples/basics/account-data/poseidon/tests/account_data.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (tests/account_data.ts:4:12)
    at Context.<anonymous> (tests/account_data.ts:40:47)
    at processImmediate (node:internal/timers:483:21)

2) Address Info Program
     edit
       edits existing address info:
   TypeError: addressProgram.methods.edit is not a function`

@0xCipherCoder
Copy link
Contributor Author

0xCipherCoder commented Nov 25, 2024

@0xCipherCoder can you check why tests are failing?

@heyAyushh I have fixed test cases that were failing due to type check. Please review.

@0xCipherCoder
Copy link
Contributor Author

0xCipherCoder commented Nov 25, 2024

@heyAyushh Tests are passing but somehow still getting

Error: No such file or directory (os error 2) Error: Tests failed

@0xCipherCoder
Copy link
Contributor Author

0xCipherCoder commented Nov 25, 2024

@heyAyushh Tests are passing but somehow still getting

Error: No such file or directory (os error 2) Error: Tests failed

@heyAyushh Apologies for the multiple reviews. Finally found the issue that program names were not matching from cargo.toml and generated program. I hope this should fix the above issue.

@heyAyushh heyAyushh closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyAyushh heyAyushh Awaiting requested review from heyAyushh

Assignees

No one assigned

Labels

account-data basics/account-data contribute:poseidon Adds a poseidon example contribution to the repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xCipherCoder @heyAyushh